Pros
Serve Country. Great Benefits provided the government. These are especially good overseas. Medical Care for Soldiers families is virtually free, Housing Allowances, Cost of Overseas Living Allowance are tax-free benefits. The commissary (Army Grocery Store) stocks good old American products all over the world. Opportunities to live overseas are awesome and facilitiate traveling while off-duty.
Cons
Deployments away from families. Months away from families takes it toll on the Soldier and the family. Often months prior to a deployment Soldiers are away from families for weeks at a time which effectively makes a the deployment time longer. The big kicker is the months that the non-deployed spouse must be a single parent. Also, in most locations opportunities for well educated spouses are quite limited.