Pros
40 hours a week is well-enforced so none of the grind associated with most of the private tech industry.
Cons
Hard to know where to begin. NSA is a Combat Support Agency, but doesn't really live up to the standards of military service (I am a retired military officer - my prior career). They like to wear the trappings of DoD culture but don't actually live that lifestyle. They accept bullying and bigotry (not experienced, but observed repeatedly), and do not hold people accountable. They recently revised their core values and actually *removed* accountability from them, which seems fitting. They will admire their problems for years, but take no actions. Behavior at the Senior Executive ranks resembles a country club - go along to get along, don't challenge one another, and keep your reserved parking at all costs. Ironically, their advisor, Simon Sinek, has a book called Leaders Eat Last but they sure do not at NSA.